-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: add a parameter to mark whether scheduling is allowed on node with expired nodemetric #2076
Conversation
7df176f
to
cc6262e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
==========================================
- Coverage 68.62% 68.58% -0.05%
==========================================
Files 430 430
Lines 39540 39639 +99
==========================================
+ Hits 27136 27188 +52
- Misses 10061 10097 +36
- Partials 2343 2354 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL cc @ZiMengSheng
…d on node with expired nodemetric Signed-off-by: lucming <2876757716@qq.com>
cc6262e
to
79f0893
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
add
enableScheduleWhenNodeMetricsExpired
parameter forloadaware
scheduler plugin to mark whether scheduling is allowed on node with expired nodemetric.it be used to address the following issues:
nodemetric
expired:avoid pods being scheduled to nodes with high load.nodemetric
expired:the actual load of the node is very low but the nodemetric is very high. It may be blocked by thefilter
phase, causing the node to be unable to schedule a new pod anymore. FYI: koord-scheduler: skip checking for nodes whose nodemetrics update time has expired #1563Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test